Ryan Pavlik
d70bdbe675
Check .empty() instead of .size() == 0
...
Found with cppcheck.
2012-01-04 07:54:46 +01:00
Ryan Pavlik
5ae8bdf49d
Pre-increment non-primitive types.
...
Found with cppcheck:
"Prefix ++/-- operators should be preferred for non-primitive
types. Pre-increment/decrement can be more efficient than
post-increment/decrement. Post-increment/decrement usually
involves keeping a copy of the previous value around and adds
a little extra code."
2012-01-04 07:53:54 +01:00
Ryan Pavlik
f859e78cb2
Exceptions should be caught by reference.
...
Found using cppcheck.
2012-01-04 07:51:35 +01:00
Daniel Diaz
db08329d8b
Add mwm _MOTIF_WM_INFO atom to advertise mwm hints capability
...
Applications like urxvt look for the _MOTIF_WM_INFO atom in order
to know if the window manager implements mwm hints. If this atom
is not found, then urxvt sets override_redirect when started with
the borderless option and falls out of the control of Fluxbox.
2012-01-04 07:45:20 +01:00
Paul Tagliamonte
0f994dbb28
No need to check if a pointer is null before de-allocating it.
...
5.3.5/2 of the C++ standard:
"In either alternative, if the value of the operand of delete is the null
pointer the operation has no effect."
2012-01-04 07:43:21 +01:00
skizzhg
a2cf6fff7b
changed encoding of nls/it_IT/Translation.m to latin1
2012-01-04 07:40:04 +01:00
Mathias Gumz
2223c879bf
moved meta-information around a little bit
2011-11-01 07:24:11 +01:00
Ryan Pavlik
aabf32a1d9
README: Add information on cross-compiling for Windows
2011-10-31 10:54:33 -05:00
Ryan Pavlik
ea5f7b56ec
src/Makefile.am,FbTk/StringUtil.cc: Search relative to the executable.
...
On Windows, prepend /DUMMYPREFIX to default paths, and replace it at
runtime with the prefix relative to the exe directory.
2011-10-31 10:54:33 -05:00
Ryan Pavlik
65cb53b685
FbTk/StringUtil.cc: Don't return mid-routine.
...
Prep for Windows dummy prefix code.
2011-10-31 10:54:33 -05:00
Ryan Pavlik
25d04827b5
main.cc,FbTk/StringUtil.cc: On windows, use USERPROFILE instead of HOME
2011-10-31 10:54:32 -05:00
Ryan Pavlik
f77f5d461b
util/Makefile.am,fluxbox-generate_menu.in: use EXEEXT
...
Needed to allow mingw-cross-env cross build
2011-10-31 10:54:09 -05:00
Ryan Pavlik
5cb7326d22
fluxbox-update_configs.cc: Fix on windows - no kill or sigusr2
2011-10-31 10:54:09 -05:00
Ryan Pavlik
3ca61475fb
FbRun.cc: Fix on windows where there is no fork
2011-10-31 10:54:09 -05:00
Ryan Pavlik
b82999c1ac
FbTk/FbString.cc,Font.cc: Windows doesn't have nl_langinfo
2011-10-31 10:54:09 -05:00
Ryan Pavlik
d4f682c7bd
FbCommands.cc: Implement ExecuteCmd for Windows
2011-10-31 10:54:09 -05:00
Ryan Pavlik
4ded38f43f
configure.in: Windows requires a library to link for catgets
2011-10-31 10:54:09 -05:00
Ryan Pavlik
f922d2d803
main.cc: Add a wrapper for two-argument mkdir on Windows
2011-10-31 10:54:09 -05:00
Ryan Pavlik
42f647553a
fluxbox.cc: ifdef the signals windows doesn't have.
2011-10-31 10:54:08 -05:00
Ryan Pavlik
b0779c413b
FbTk/Timer.cc: Check HAVE_SYS_SELECT_H, add alternate for windows
2011-10-31 10:54:08 -05:00
Ryan Pavlik
5bf23bb05d
Merge branches 'fix-out-of-range-memory', 'obey-configure' and 'other-improvements' into windows-mingw
2011-10-31 10:53:05 -05:00
Ryan Pavlik
afa870802b
FbTk/App.cc: make startup failure easier to diagnose
2011-10-31 10:51:51 -05:00
Ryan Pavlik
d5b58a8033
main.cc: Use expandFilename for default paths
2011-10-31 10:51:45 -05:00
Ryan Pavlik
7510c2d173
src/Makefile.am: Add warning to defaults.cc as well
2011-10-31 10:51:41 -05:00
Ryan Pavlik
fa63fcdc66
main.cc: Check getenv output better.
...
Windows returns pointers to empty strings for non-existent env vars.
2011-10-31 10:51:38 -05:00
Ryan Pavlik
9a2c6f94b8
configure.in, acinclude.m4: always pre-pend new libs.
2011-10-31 10:51:30 -05:00
Ryan Pavlik
75c6cee969
FbTk/FileUtil.cc: Use only file masks defined.
...
Needed for mingw-cross-env
2011-10-31 10:51:13 -05:00
Ryan Pavlik
cc1193ef0c
FbTk/SignalHandler.cc: Use HAVE_SIGACTION, with signal() fallback
...
This fixes platforms without sigaction, like Windows.
2011-10-31 10:50:26 -05:00
Ryan Pavlik
f40be36f75
FbTk/Timer.cc: Check HAVE_SYS_SELECT_H
2011-10-31 10:47:59 -05:00
Ryan Pavlik
757f78035d
FbTk/StringUtil.cc: Fix out-of-range memory access.
...
if pos is not npos, it will always be less than filename.size().
However, the access later is only safe if there is a character
after pos, which would require pos + 1 to be less than filename.size.
2011-10-31 10:44:11 -05:00
Ryan Pavlik
60c964a4d9
RootTheme.cc: Obey HAVE_SYS_WAIT_H
2011-10-31 10:42:08 -05:00
Ryan Pavlik
4bad431c90
main.cc: Only sync() if we can.
2011-10-31 10:42:06 -05:00
Ryan Pavlik
97b48ccb12
configure.in: Check for sync()
2011-10-31 10:42:03 -05:00
Ryan Pavlik
c944c8c0b3
fluxbox.cc: check HAVE_SYS_WAIT_H
2011-10-31 10:42:00 -05:00
Ryan Pavlik
f47ed1be51
FbTk/I18n.cc: Constructor should also check defined(NLS)
2011-10-31 10:41:32 -05:00
Mathias Gumz
1ba4fbe878
Prepare 1.3.2 release
2011-10-28 21:09:05 +02:00
skizzhg
05d3c55763
Proofreading nls/it_IT/Translation.m and added_myself to translators.txt
2011-10-23 20:06:35 +02:00
Mathias Gumz
fe0eda27bd
bugfix: use the imlib cache for every imlib context used
...
calling imlib_set_cache_size() before a context is created by fluxbox creates
an 'unknown' context. that one is never freed at shutdown.
2011-10-23 11:58:32 +02:00
Mathias Gumz
a545ddef17
clean up imlib2 loaders at shutdown
2011-10-23 11:52:05 +02:00
Mathias Gumz
2628a0a4cf
clean up resources on shutdown
2011-10-23 11:51:36 +02:00
Mathias Gumz
3fa30a4c82
updated ChangeLog
2011-10-23 09:02:18 +02:00
Mathias Gumz
dc18666ef2
small code simplification
2011-10-23 09:01:19 +02:00
Mathias Gumz
ee34b376d7
Bugfix: clean up static resources correctly
...
93924af160
might corrupt memory with gcc-4.6.1 when
finishing fluxbox (clicking 'exit', sending it a SIGINT). Allthough the order, in which static / global
objects are initialized is undefined (at least between separate compilation units), the order in
which they are destroyed is well defined: in reverse order of initialization.
this means, that if 'ScreenImlibContextContainer contexts' (of ImageImlib2.cc)
gets initialized AFTER 'ImageImlib2 imlib2_loader' of Image.cc, it gets destroyed before
imlib2_loader. When that happens, ~ImageImlib2() works on a destroyed object.
(That lead to '* glibc detected * fluxbox: corrupted double-linked list: 0x0000000000dd2710 ***'
later on in 'iconv_close')
2011-10-23 00:01:45 +02:00
Mathias Gumz
3f76e117bf
refactored MenuCreator
...
make public only what needs to be public
2011-10-21 08:42:48 +02:00
Mathias Gumz
8dd11efc76
cosmetics
2011-10-21 08:34:53 +02:00
Mathias Gumz
4f4d5e25d9
bugfix: fbsetroot needs to use 24bit visuals as well
...
12f44680df
introduced ARGB visuals. if fluxbox
creates 32bit visuals for the container window or the root window: does not work.
2011-10-21 08:34:37 +02:00
Gediminas Liktaras
12f44680df
Added support for ARGB visual, patch #3284774
...
fluxbox now properly displays windows that require ARGB visuals when
an external compositor is running. This was done by creating the
container window with the correct visual and colormap when needed.
Closes #2874629
2011-10-20 09:41:55 +02:00
Mathias Gumz
b2b65dea7f
fixed typo in startfluxbox manpage
2011-10-20 07:54:47 +02:00
Mathias Gumz
6601d9e50e
updated ChangeLog
2011-10-17 17:08:27 +02:00
Mathias Gumz
a2558a2b14
removed obsolete handler for the gnome-window manager hints
...
nowadays every app should use the extended window manager hints exclusively.
2011-10-17 17:07:00 +02:00