nilix/fluxbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
fluxbox/src
History
Pavel Labath 16c90dc19f Make SignalTracker always disconnect itself from Signals 
previously, the tracker disconnected itself only when the caller passed withTracker = true to the
leave() function. However, the default value was for the parameter was false.

Non disconnecting from signal when stopping tracking creates very dangerous situation because the
signal still holds a pointer to the tracker. This resulted in a segfault when exiting fluxbox,
because the tracker (FluxboxWindow) got destroyed before the signal (BScreen::focusedWindowSig),
and the signal was using an invalid pointer when it tried to disconnect itself from the tracker.

Instead of setting withTracker to true by default or changing all invocations of leave(), I
decided to make the tracker disconnect itself unconditionally because I could not find a use case
for the opposite behaviour.

PS: This message is in fact longer than the actual commit.
2011-05-10 13:00:46 +02:00
..
FbTk Make SignalTracker always disconnect itself from Signals 2011-05-10 13:00:46 +02:00
tests Remove Observers from testSignal.cc 2011-05-10 13:00:46 +02:00
AlphaMenu.cc renamed FbTk::XLayer to FbTk::Layer and FbTk::XLayerItem to FbTk::LayerItem 2011-02-23 22:49:27 +01:00
AlphaMenu.hh renamed FbTk::XLayer to FbTk::Layer and FbTk::XLayerItem to FbTk::LayerItem 2011-02-23 22:49:27 +01:00
ArrowButton.cc added FbTk::Util::clamp() and simplified related code 2010-09-09 15:31:54 +02:00
ArrowButton.hh remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
AtomHandler.hh code simplification 2010-09-13 22:04:24 +02:00
AttentionNoticeHandler.cc Remove all trace of Observers and Subjects 2011-05-10 13:00:46 +02:00
AttentionNoticeHandler.hh Convert Focusable::dieSig to FbTk::Signal 2011-05-10 13:00:45 +02:00
ButtonTheme.cc remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
ButtonTheme.hh Last round of simplification of Signal/Slot classes 2011-05-10 13:00:45 +02:00
ButtonTool.cc bugfix: consistent use of 'int' for alpha values (#3187373) 2011-02-22 22:07:39 +01:00
ButtonTool.hh bugfix: consistent use of 'int' for alpha values (#3187373) 2011-02-22 22:07:39 +01:00
CascadePlacement.cc remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
CascadePlacement.hh remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
ClientMenu.cc Convert Focusable::dieSig to FbTk::Signal 2011-05-10 13:00:45 +02:00
ClientMenu.hh Convert Focusable::dieSig to FbTk::Signal 2011-05-10 13:00:45 +02:00
ClientPattern.cc Can check CARDINAL properties in CLIENT PATTERNS 2011-05-08 07:48:03 +02:00
ClientPattern.hh added 'SetXProp' action and (@PROP=foo) clientpattern 2010-09-11 17:09:07 +02:00
ClockTool.cc Convert ToolbarItem::resizeSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
ClockTool.hh Convert FbTk::Theme::reconfigSig and friends to the new Signal system 2011-05-10 13:00:45 +02:00
ColSmartPlacement.cc cosmetic 2010-09-08 22:31:41 +02:00
ColSmartPlacement.hh remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
CommandDialog.cc Make RefCount<> more sensible 2011-05-10 13:00:45 +02:00
CommandDialog.hh add SetTitle and SetTitleDialog key commands 2008-08-17 04:10:17 -07:00
CurrentWindowCmd.cc Convert Focusable::dieSig to FbTk::Signal 2011-05-10 13:00:45 +02:00
CurrentWindowCmd.hh make Raise/LowerLayer accept integer argument for number of layers, default 2 2009-06-28 10:15:06 -07:00
Debug.hh Changed #ifdef DEBUG ... cerr << to using fbdbg. 2010-03-17 16:35:07 +01:00
Ewmh.cc Can check CARDINAL properties in CLIENT PATTERNS 2011-05-08 07:48:03 +02:00
Ewmh.hh remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
FbAtoms.cc simpler way of expressing 'Singleton' for 'FbAtoms' 2010-09-08 22:09:06 +02:00
FbAtoms.hh simpler way of expressing 'Singleton' for 'FbAtoms' 2010-09-08 22:09:06 +02:00
FbCommands.cc moved Menu placement into ScreenPlacement::placeAndShowMenu() 2011-02-24 11:21:16 +01:00
FbCommands.hh allow restart with no argument from fluxbox-remote 2008-06-19 18:58:34 -07:00
FbMenu.cc renamed FbTk::XLayer to FbTk::Layer and FbTk::XLayerItem to FbTk::LayerItem 2011-02-23 22:49:27 +01:00
FbMenu.hh renamed FbTk::XLayer to FbTk::Layer and FbTk::XLayerItem to FbTk::LayerItem 2011-02-23 22:49:27 +01:00
FbMenuParser.cc remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
FbMenuParser.hh remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
FbRootWindow.cc ignore XRandr events that don't actually change the screen size 2008-10-14 19:40:33 -07:00
FbRootWindow.hh ignore XRandr events that don't actually change the screen size 2008-10-14 19:40:33 -07:00
FbWinFrame.cc Convert FbWinFrame::frameExtentSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
FbWinFrame.hh Convert FbWinFrame::frameExtentSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
FbWinFrameTheme.cc added FbTk::Util::clamp() and simplified related code 2010-09-09 15:31:54 +02:00
FbWinFrameTheme.hh Last round of simplification of Signal/Slot classes 2011-05-10 13:00:45 +02:00
fluxbox.cc Convert FluxboxWindow::layerSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
fluxbox.hh Convert FluxboxWindow::layerSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
Focusable.hh Convert Focusable::attentionSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
FocusableList.cc Convert FluxboxWindow::layerSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
FocusableList.hh Remove all trace of Observers and Subjects 2011-05-10 13:00:46 +02:00
FocusableTheme.hh Remove all trace of Observers and Subjects 2011-05-10 13:00:46 +02:00
FocusControl.cc disabled overhead base classes 'FbTk::Layer' and 'FbTk::LayerItem' 2011-02-23 22:46:13 +01:00
FocusControl.hh Implement StrictMouseFocus 2010-05-28 15:50:15 -04:00
FocusModelMenuItem.hh add selection box to various "choose one of these" menu items 2008-08-03 21:59:14 -07:00
GenericTool.cc Convert FbTk::Theme::reconfigSig and friends to the new Signal system 2011-05-10 13:00:45 +02:00
GenericTool.hh Convert FbTk::Theme::reconfigSig and friends to the new Signal system 2011-05-10 13:00:45 +02:00
Gnome.cc Can check CARDINAL properties in CLIENT PATTERNS 2011-05-08 07:48:03 +02:00
Gnome.hh remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
HeadArea.cc updated copyright info 2006-02-16 06:53:05 +00:00
HeadArea.hh removed some unneeded headers 2007-12-30 16:32:53 +01:00
IconbarTheme.cc added new ThemeProxy for automatically handling focused vs. unfocused ThemeItems 2008-01-07 02:26:32 -08:00
IconbarTheme.hh Last round of simplification of Signal/Slot classes 2011-05-10 13:00:45 +02:00
IconbarTool.cc Convert Focusable::orderSig,addSig,removeSig,resetSig to FbTk::Signal 2011-05-10 13:00:45 +02:00
IconbarTool.hh Convert Focusable::orderSig,addSig,removeSig,resetSig to FbTk::Signal 2011-05-10 13:00:45 +02:00
IconButton.cc Convert Focusable::attentionSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
IconButton.hh Convert Focusable::attentionSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
Keys.cc Make RefCount<> more sensible 2011-05-10 13:00:45 +02:00
Keys.hh added OnLeftGrip, OnRightGrip, OnWindowBorder modifiers for keys file 2010-05-05 08:41:03 +02:00
Layer.hh compile fix: sunCC 5.11 (sunstudio 12) compiles and links again 2011-03-23 12:02:15 +01:00
LayerMenu.cc compile fix: sunCC 5.11 (sunstudio 12) compiles and links again 2011-03-23 12:02:15 +01:00
LayerMenu.hh renamed FbTk::XLayer to FbTk::Layer and FbTk::XLayerItem to FbTk::LayerItem 2011-02-23 22:49:27 +01:00
main.cc updated year and copyright info 2011-02-23 21:42:51 +01:00
Makefile.am Include src/tests in the distribution tarball 2011-05-07 12:39:04 +02:00
MenuCreator.cc Make RefCount<> more sensible 2011-05-10 13:00:45 +02:00
MenuCreator.hh allow window menu items in ordinary menus 2008-06-06 06:58:20 -07:00
MinOverlapPlacement.cc code cleanup: moved code from public API to implementation 2011-03-19 19:29:43 +01:00
MinOverlapPlacement.hh code cleanup: moved code from public API to implementation 2011-03-19 19:29:43 +01:00
OSDWindow.cc introduced FbTk::BidiString 2010-09-08 20:17:21 +02:00
OSDWindow.hh introduced FbTk::BidiString 2010-09-08 20:17:21 +02:00
PlacementStrategy.hh remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
RectangleUtil.hh added RectangleUtil::overlapRectangles() + test cases 2011-03-19 14:56:45 +01:00
Remember.cc Make RefCount<> more sensible 2011-05-10 13:00:45 +02:00
Remember.hh allow to override 'FocusNewWindow' via .fluxbox/apps 2011-02-03 18:51:10 +01:00
Resources.cc compile fix: sunCC 5.11 (sunstudio 12) compiles and links again 2011-03-23 12:02:15 +01:00
RootCmdMenuItem.cc make FbTk::Command a template class, split parsing information out of ObjectRegistry 2008-01-10 23:41:22 -08:00
RootCmdMenuItem.hh remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
RootTheme.cc Changed #ifdef DEBUG ... cerr << to using fbdbg. 2010-03-17 16:35:07 +01:00
RootTheme.hh Last round of simplification of Signal/Slot classes 2011-05-10 13:00:45 +02:00
RowSmartPlacement.cc remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
RowSmartPlacement.hh remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
Screen.cc Convert Screen::reconfigureSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
Screen.hh Remove all trace of Observers and Subjects 2011-05-10 13:00:46 +02:00
ScreenPlacement.cc code cleanup: moved code from public API to implementation 2011-03-19 19:29:43 +01:00
ScreenPlacement.hh code cleanup: moved code from public API to implementation 2011-03-19 19:29:43 +01:00
SendToMenu.cc Remove all trace of Observers and Subjects 2011-05-10 13:00:46 +02:00
SendToMenu.hh Remove all trace of Observers and Subjects 2011-05-10 13:00:46 +02:00
Slit.cc Convert Screen::reconfigureSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
Slit.hh Convert Screen::reconfigureSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
SlitClient.cc introduced FbTk::BidiString 2010-09-08 20:17:21 +02:00
SlitClient.hh introduced FbTk::BidiString 2010-09-08 20:17:21 +02:00
SlitTheme.cc remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
SlitTheme.hh Last round of simplification of Signal/Slot classes 2011-05-10 13:00:45 +02:00
Strut.hh remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
StyleMenuItem.cc add selection box to various "choose one of these" menu items 2008-08-03 21:59:14 -07:00
StyleMenuItem.hh add selection box to various "choose one of these" menu items 2008-08-03 21:59:14 -07:00
SystemTray.cc Convert ToolbarItem::resizeSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
SystemTray.hh Convert FbTk::Theme::reconfigSig and friends to the new Signal system 2011-05-10 13:00:45 +02:00
TextDialog.cc introduced FbTk::BidiString 2010-09-08 20:17:21 +02:00
TextDialog.hh introduced FbTk::BidiString 2010-09-08 20:17:21 +02:00
ToggleMenu.hh renamed FbTk::XLayer to FbTk::Layer and FbTk::XLayerItem to FbTk::LayerItem 2011-02-23 22:49:27 +01:00
Toolbar.cc Convert ToolbarItem::resizeSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
Toolbar.hh Convert ToolbarItem::resizeSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
ToolbarItem.cc remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
ToolbarItem.hh Convert ToolbarItem::resizeSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
ToolbarTheme.cc remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
ToolbarTheme.hh Last round of simplification of Signal/Slot classes 2011-05-10 13:00:45 +02:00
ToolFactory.cc Make RefCount<> more sensible 2011-05-10 13:00:45 +02:00
ToolFactory.hh cosmetic fixes: removed redundant ';' + some whitespaces 2009-09-30 21:02:24 +02:00
ToolTheme.cc add a level of indirection to themes 2008-01-04 01:06:38 -08:00
ToolTheme.hh Last round of simplification of Signal/Slot classes 2011-05-10 13:00:45 +02:00
TooltipWindow.cc introduced FbTk::BidiString 2010-09-08 20:17:21 +02:00
TooltipWindow.hh introduced FbTk::BidiString 2010-09-08 20:17:21 +02:00
UnderMousePlacement.cc remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
UnderMousePlacement.hh remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
WinButton.cc Convert FluxboxWindow::stateSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
WinButton.hh Remove all trace of Observers and Subjects 2011-05-10 13:00:46 +02:00
WinButtonTheme.cc The unfocused/pressed pixmaps for the 'stick' button were ignored. 2008-03-19 21:02:47 +01:00
WinButtonTheme.hh Last round of simplification of Signal/Slot classes 2011-05-10 13:00:45 +02:00
WinClient.cc Convert Focusable::dieSig to FbTk::Signal 2011-05-10 13:00:45 +02:00
WinClient.hh Can check CARDINAL properties in CLIENT PATTERNS 2011-05-08 07:48:03 +02:00
Window.cc Convert FbWinFrame::frameExtentSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
Window.hh Remove all trace of Observers and Subjects 2011-05-10 13:00:46 +02:00
WindowCmd.cc remove old svn $Id$ tags 2008-01-03 17:34:12 -08:00
WindowCmd.hh more more fun with the window menu 2008-05-28 02:32:57 -07:00
WindowMenuAccessor.hh bugfix: consistent use of 'int' for alpha values (#3187373) 2011-02-22 22:07:39 +01:00
WindowState.cc minor cleanup 2010-09-09 15:33:34 +02:00
WindowState.hh compile fix: sunCC 5.11 (sunstudio 12) compiles and links again 2011-03-23 12:02:15 +01:00
Workspace.cc better solution for warping transient windows 2011-02-24 16:55:55 +01:00
Workspace.hh Last round of simplification of Signal/Slot classes 2011-05-10 13:00:45 +02:00
WorkspaceCmd.cc Make RefCount<> more sensible 2011-05-10 13:00:45 +02:00
WorkspaceCmd.hh added 'ArrangeWindowsVertical' to actions 2010-09-17 16:22:33 +02:00
WorkspaceMenu.cc compile fix: sunCC 5.11 (sunstudio 12) compiles and links again 2011-03-23 12:02:15 +01:00
WorkspaceMenu.hh Changed workspace names signal in BScreen to use the new signal system 2008-09-21 15:25:47 +02:00
WorkspaceNameTheme.hh Last round of simplification of Signal/Slot classes 2011-05-10 13:00:45 +02:00
WorkspaceNameTool.cc Convert ToolbarItem::resizeSig to FbTk::Signal 2011-05-10 13:00:46 +02:00
WorkspaceNameTool.hh Convert FbTk::Theme::reconfigSig and friends to the new Signal system 2011-05-10 13:00:45 +02:00
Xinerama.hh renamed FbTk::XLayer to FbTk::Layer and FbTk::XLayerItem to FbTk::LayerItem 2011-02-23 22:49:27 +01:00
Xutil.cc introduced FbTk::BidiString 2010-09-08 20:17:21 +02:00
Xutil.hh introduced FbTk::BidiString 2010-09-08 20:17:21 +02:00