Commit graph

4060 commits

Author SHA1 Message Date
Pavel Labath
8b6943ab1c Fix a couple of "comparison between signed and unsigned" warnings 2011-04-15 21:36:04 +02:00
David Coppa
870d4d02ee bugfix: use 'unsigned long' to feed XChangeProperty, closes #3285968
old code crashed on sparc64, pid_t seems to be 32bit on that platform.
2011-04-14 15:08:02 +02:00
Pavel Labath
a83cedf37e Fix a pair of warnings reported by clang 2011-04-11 08:37:58 +02:00
Pavel Labath
91958279d3 Menu.cc: send debug output to cerr, make the output more sensible 2011-04-11 08:31:52 +02:00
Gediminas Liktaras
b1d70e2c92 bugfix: return 'height' if container is rotated vertically, closes #3195728
iconbar.iconWidth property was ignored due this bug.
2011-04-03 13:20:35 +02:00
Daniel Diaz
d28e105075 compile fix: added <cstdlib> to provide declaration for 'size_t' (gcc-4.6.x likes it that way) 2011-03-28 09:06:22 +02:00
Mathias Gumz
d4f7f17330 compile fix: arguments must match declaration
Sun CC++ 5.11 complaint on linking about missing symbols 'nextWorkspace()',
'prevWorkspace()' etc.
2011-03-23 18:45:34 +01:00
Mathias Gumz
745fb8e71c removed useless code 2011-03-23 18:41:48 +01:00
Mathias Gumz
21022a1952 cosmetics 2011-03-23 12:03:17 +01:00
Mathias Gumz
9086ccafbe compile fix: sunCC again, wants a compile time constant for arrays 2011-03-23 12:03:08 +01:00
Mathias Gumz
e850b01919 compile fix: sunCC 5.11 (sunstudio 12) compiles and links again
biggest change: renaming of 'class Layer' to 'class ResourceLayer' in
Layer.hh to handle complaints about 'ambiguous Layer: Layer or FbTk::Layer'.
'ResourceLayer' sounds crappy, but that was the best I could come
up with right now.
2011-03-23 12:02:15 +01:00
Mathias Gumz
7ece90ad4f merge 2011-03-19 20:12:05 +01:00
Mathias Gumz
9f2c37341c code cleanup: moved code from public API to implementation
renamed 'Region' to 'Area' to avoid conflicts with 'Region' from Xlib.
2011-03-19 19:29:43 +01:00
Henrik Kinnunen
0b6c860fa0 delete config menu first at shutdown 2011-03-19 19:19:26 +01:00
Mathias Gumz
97e08c3853 bugfix: reposition windows only if they are invisible
changing the layout or the number of the attached monitors
might lead to invisible windows. only those windows should be
positioned to the closest monitor, if they are not visible
already.
2011-03-19 15:05:39 +01:00
Mathias Gumz
c200045e9a code deduplication: use RectangleUtil::insideBorder() 2011-03-19 15:01:16 +01:00
Mathias Gumz
767afd32f3 prepare BScreen::XineramaHeadInfo to be 'RectangleLike' 2011-03-19 15:00:34 +01:00
Mathias Gumz
a798e0e0ff added RectangleUtil::overlapRectangles() + test cases 2011-03-19 14:56:45 +01:00
Mathias Gumz
bcae4e257d added tests/testRectangleUtil.cc 2011-03-18 17:57:34 +01:00
Mathias Gumz
253f13d46e some love to src/tests, use automake to use the same build environment as the rest of fluxbox 2011-03-18 15:51:17 +01:00
Mathias Gumz
81b240e976 compile fix for clang, forward declaration of FocusControl was not enough 2011-03-18 11:01:08 +01:00
Mathias Gumz
3a3df51823 compiler cosmetic: changed return type of ScreenPlacement::placeAndShowMenu() to void, closes #3204402 2011-03-18 07:53:53 +01:00
Mathias Gumz
a53017cc3b bugfix: do not use anything from the current ClientMenuItem after m_client.focus(), closes #3210493
m_client.focus() might call ~ClientMenuItem(), thus m_client is not available anymore. the crash was triggered by trying to deiconify a client via the clientmenu. this triggers a signal to remove and destroy the current ClientMenuItem.
2011-03-15 09:49:06 +01:00
Mathias Gumz
bb2ce5df8a fix misordered Toolbar::Placement strings, closes 3195721 2011-03-01 14:32:21 +01:00
Mathias Gumz
d2e7feaa85 bugfix: submenus didn't hide if a delay was set
use the FbTk::Timer API correctly, bug(s) introduced by

   1f0adef4da
   e685117941
2011-02-25 18:39:48 +01:00
Mathias Gumz
798ecb88d5 cache result of getWorkspace() 2011-02-24 16:56:53 +01:00
Mathias Gumz
4a161132c2 better solution for warping transient windows
see #3088856 / 09f99a4674.

at the moment this fix looks side-effect free, time will tell.
2011-02-24 16:55:55 +01:00
Mathias Gumz
09f99a4674 intermediate fix for segfault when warping transient windows to different workspace, see #3088856
warping a transient window to the next workspace creates a cycle between
BScreen::changeWorkspaceID(), BScreen::reassociateWindow(), Workspace::removeWindow(),
FocusControl::unfocusWindow(), FluxboxWindow::setCurrentClient(), FluxboxWindow::focus()
and so on.

for now we just stop allowing transient windows to be warped, it is most
likely a bad idea anyway having the modal dialog on one workspace and the
(dead) main window on another one.

this issue must be analyzed further, since there might be a deeper problem
with the way the focus code works.
2011-02-24 15:59:34 +01:00
Mathias Gumz
35753c7c3f fix calculating the width / height of SystemTray (closes #3150939) 2011-02-24 15:00:22 +01:00
Mathias Gumz
39871695cf SystemTray tool should use the right fallback resource 2011-02-24 14:58:15 +01:00
Mathias Gumz
3c924a251a removed unused headers 2011-02-24 11:21:29 +01:00
Mathias Gumz
f0ffaf890f moved Menu placement into ScreenPlacement::placeAndShowMenu() 2011-02-24 11:21:16 +01:00
Mathias Gumz
49623390b6 little helper function 'isTitleVisible()' for FbTk::Menu 2011-02-24 11:17:48 +01:00
Mathias Gumz
1bb30855bb code deduplication 2011-02-24 11:16:16 +01:00
Mathias Gumz
6febc40c47 bugfix: place WindowMenu correctly upon first call (closes #2731524)
FbTk::Menu::updateMenu() recalculates the width() and height() of the
window. this must be done before the menu is moved to fit completely
onto the screen.

the 'menu().raise()' command is not needed, that is done inside
'menu().show()' already.
2011-02-24 00:26:32 +01:00
Mathias Gumz
9616a676d8 renamed FbTk::XLayer to FbTk::Layer and FbTk::XLayerItem to FbTk::LayerItem 2011-02-23 22:49:27 +01:00
Mathias Gumz
813e6c4402 disabled overhead base classes 'FbTk::Layer' and 'FbTk::LayerItem'
had to add <algorithm> at various other files as a result of this change.
2011-02-23 22:46:13 +01:00
Mathias Gumz
c859ae3987 irrelevant 'virtual' destructor 2011-02-23 21:47:16 +01:00
Mathias Gumz
32cc4ba69b code deduplication 2011-02-23 21:45:50 +01:00
Mathias Gumz
504fd5c4fa updated year and copyright info 2011-02-23 21:42:51 +01:00
Mathias Gumz
1797d6895c almost 10 years of fluxbox 2011-02-23 17:19:27 +01:00
Henrik Kinnunen
23d67b7f14 merged crash fix 2011-02-23 07:54:20 +01:00
Henrik Kinnunen
bb3f955e0f Fixed possible crash issue when getting an unmap before a focus in event.
The issue was caused by a client that got an unmap notify and had a FocusIn event
directly after in the event queue. The focus in event was handled by Fluxbox::revertFocus
before the WinClient.cc removed itself from the search window list.
2011-02-23 07:38:45 +01:00
Mathias Gumz
6fb2960756 moved rarely used 'cpccpc' out of class declaration 2011-02-22 22:33:56 +01:00
Mathias Gumz
4f921f77f4 don't use hardcoded references to positions in the menu 2011-02-22 22:17:11 +01:00
Mathias Gumz
d11aa42ace bugfix: consistent use of 'int' for alpha values (#3187373)
WindowMenuAccessor returned strange alpha values if compiled
with 'g++ -Os'; unholy black magic happens if template<int> faces
functions returning only 'usigned char'.
2011-02-22 22:07:39 +01:00
Mathias Gumz
b7e84104a6 bugfix: render 'sunken' gradients correctly 2011-02-22 15:53:18 +01:00
Mathias Gumz
3c7407beb4 use FbTk::StringUtil API 2011-02-22 15:18:53 +01:00
Mathias Gumz
84a81a1ac1 renamed Texture:DEFAULT_BEVEL to Texture::DEFAULT_LEVEL 2011-02-22 15:18:20 +01:00
Mathias Gumz
0569849c6d cosmetics 2011-02-22 15:17:15 +01:00