Commit graph

494 commits

Author SHA1 Message Date
Dana Jansens
9f11e2af6b cycling between dock windows now possible with the <panels>yes</panels> option 2007-04-23 22:40:33 +00:00
Mikael Magnusson
9e7a240dfd include the header that has gethostname 2007-04-23 19:02:33 +00:00
Mikael Magnusson
141c249b8c show the hostname of forwarded clients in the titlebar 2007-04-23 18:46:19 +00:00
Dana Jansens
a82c1efeed wasteful syncing 2007-04-23 02:00:33 +00:00
Dana Jansens
7e0d660b8b stop listening to events on clients that are being unmanaged before generating new events 2007-04-22 22:56:53 +00:00
Dana Jansens
037654f3f8 use ignore enters instead of removing them from the queue 2007-04-22 16:48:35 +00:00
Dana Jansens
27773e1cb7 don't grab the pointer during interactive events. this allows you to alt-tab during a dnd. 2007-04-22 15:22:25 +00:00
Dana Jansens
a70633d42a eat enter events after unmanaging a window
change how focus falls back for windows being unmanaged, don't fall back immediately, instead wait for the focus out event and use it (break stuff maybe! yay)
2007-04-22 13:53:28 +00:00
Dana Jansens
6e7abeb860 engrish 2007-04-22 04:35:23 +00:00
Dana Jansens
8a972b3879 ignore BadMatch errors that can't be avoided 2007-04-21 21:36:02 +00:00
Dana Jansens
0e9bd66b75 fixes for transients
1) don't count non-normal windows as parents when placing/stacking transients
2) in stacking.c, when a window is transient for the group but has no parents, then don't loop forever looking for its parents
2007-04-21 21:32:21 +00:00
Dana Jansens
d713bdf462 remove the client_time_heap thing. actually its better to just use the user_time on the currently focused window I think. that will handle panels and things too. 2007-04-20 05:22:23 +00:00
Dana Jansens
90cd9c6219 get rid of global client_last_user_time variable.
add ObClientTimeHeap. This is a max-heap of the clients based on their user times. this only includes the clients whose user time is not CurrentTime. the maximum from this heap replaces the client_last_user_time variable, so that you always have the latest time, not the last time that was changed.

hoefully it works, so far it seems to.
2007-04-18 19:22:59 +00:00
Dana Jansens
64dda2375e saved session information overrides per-app settings, because that's how you set it up in the session 2007-04-12 14:54:54 +00:00
Dana Jansens
33c469f453 set the desktop from per-app-settings properly, i think.
also fix a compiler warning.
2007-04-12 14:47:54 +00:00
Dana Jansens
7a1a6da849 better synthetic configurenotify handling. in particular..
http://bugzilla.gnome.org/show_bug.cgi?id=399552
on unmap, when we move the client window, we need to send a synthetic configurenotify.
2007-04-12 14:44:17 +00:00
Dana Jansens
c03c08415f don't fallback when a window is hidden right away, it's redundant, we'll get a focusout for the window after the unmapnotify anyways.
show new windows when switching desktops before hiding the old windows.
2007-04-12 02:26:26 +00:00
Dana Jansens
7059cde13b http://mail.gnome.org/archives/wm-spec-list/2006-May/msg00000.html
Send ConfigureNotify events when a window is mapped at the position it has specified. When we add decorations, the window gets moved in reference to the root window, so it needs to be told.
2007-04-05 03:59:24 +00:00
Dana Jansens
0eaf2d15e7 fully maximize windows all the time. size increments are preferred sizes not required ones.
-- http://tronche.com/gui/x/icccm/sec-4.html#s-4.1.2.3
2007-03-30 04:37:53 +00:00
Dana Jansens
00ddaf06bb can't use (unsigned)-1 for a max time, because timestamps wraparound and stuff. user the last_user_time as a default for new windows instead. 2007-03-28 19:57:07 +00:00
Dana Jansens
33cc572402 drop some wasted client_validates. 2007-03-28 02:00:10 +00:00
Dana Jansens
d20f84f5de more handling time wraparounds 2007-03-28 01:53:37 +00:00
Dana Jansens
339d767044 handle time wrapping around. 2007-03-28 01:52:06 +00:00
Dana Jansens
eb2a0feb01 watch for reverttoparent reverting to the root window, which will create a DetailInferior focusin event on root.
adding some debug messages also which I am using..
2007-03-24 23:19:45 +00:00
Dana Jansens
c4732aeed2 2007-03-24 17:17:02 +00:00
Dana Jansens
e77353f0cd clean up the title getting function 2007-03-24 17:06:19 +00:00
Dana Jansens
4c2b16e72d kill window title numbering...
probably it was a dumb idea all along. you're not picking the numbers yourself and you're probably not remembering which window they apply to and the focus indicator thinger is much more clever than numbers
2007-03-24 17:01:40 +00:00
Dana Jansens
fb3d2033ba not passing timestamps sometimes and not others. set event_curtime when client messages provide a timestamp. 2007-03-19 17:59:16 +00:00
Dana Jansens
5fa443efc8 oops, logic error 2007-03-17 20:06:16 +00:00
Dana Jansens
73dac2b9b9 fix for bug introduced in revision 5643. logical size is supposed to be updated only when the window is resized. 2007-03-16 19:14:53 +00:00
Dana Jansens
adc5675823 oh, 2 things in this commit..
1) THIS ONE IS IMPORTANT: don't set client->iconfied if the window is not actually going to be allowed to iconify. heh!

2) changes to focus fallback to avoid crashing and to avoid losing focus all at the same time.
2007-03-14 15:51:21 +00:00
Mikael Magnusson
768ce7b456 move stuff around in client_unmanage to maybe make closing windows a bit nicer 2007-03-14 14:17:31 +00:00
Dana Jansens
5f7ffb00ba refix for managing iconic windows, without having the frame map which caused flashing.
instead, keep track of if the frame has been mapped yet. if it hasn't and it is getting hidden, then make sure to unmap the child.
2007-03-14 13:58:36 +00:00
Dana Jansens
e2521f5c64 a) fix resizerelative moving windows when they reach their minimum size do this by...
b) adding a function to let you see what size/position a window will be given when you actually try move/resize it to some given values. (client_try_configure)
2007-03-14 03:45:56 +00:00
Dana Jansens
594648729f less wasted updates of wm_state 2007-03-14 02:07:30 +00:00
Mikael Magnusson
53109b7592 comparing strings to random locations in memory is probably not what we wanted to do 2007-03-13 12:34:58 +00:00
Dana Jansens
a9910e520b always unfocus the window when it disappears, no special cases.. (except unmanage) 2007-03-13 04:15:25 +00:00
Dana Jansens
270a5b25df set IconicState on windows that are not visible always. this means windows on other desktops too.
as well, this turned out to be a nice cleanup of the wmstate code.

regards to the random dude in #openbox complaining about the ICCCM to make me think to look this up and see if openbox was compliant.
2007-03-13 04:04:13 +00:00
Dana Jansens
7f58bd9eaa save and restore pre-maximized/fullscreen sizes properly
much cleanup on how per-app settings are applied to new mapping windows. maybe i broke it? but it'll be much quicker now, and it's consistant with the rest of the code, so hooray for that. pls let me know if i broke any of it :( hee..
2007-03-13 02:29:08 +00:00
Dana Jansens
d47c6a0979 fallback is still getting x errors. instead, fallback when the client iconifies, and don't fallback when nothing has focus, send it to where we can control things though. 2007-03-12 17:31:11 +00:00
Dana Jansens
85a1a0cfb3 don't validate inside client_focus. instead, validate before you call it! 2007-03-12 06:04:00 +00:00
Dana Jansens
6b7cc88c9d validate clients before trying to focus them in fallback
also validate before trying to set the focus on a window

this should fix those crashes, and should just be better over all
2007-03-12 05:57:30 +00:00
Dana Jansens
c018e21220 i rewrote handling of focus events. this is pretty much based on blackbox's current form, as well as reading the xlib programming manual at:
http://tronche.com/gui/x/xlib/events/input-focus/normal-and-grabbed.html

this may break for people. that'd be nice to hear about, so it can be fixed. but hopefully this is more robust. it sure is a lot more simple.
2007-03-12 05:25:34 +00:00
Dana Jansens
d33f44cd86 Rewrite the stacking code. It's a lot faster now, I should think. It's def a more clever algorithm. It deals with group transients much better.
On that note, utility and menu and toolbar window types are now treated as group transients in terms of stacking and focus and such.
2007-03-12 02:24:40 +00:00
Dana Jansens
e2b3a32aed We were grabbing SubstructureNotifyMask on the root window. I don't know why.. It meant that we got unmap notifies for windows we weren't even managing and stuff. It ended up breaking VLC when it mapped-unmapped-mapped a window. We grab StructureNotify for all the clients, so I am not sure why this was ever there. 2007-03-11 22:16:42 +00:00
Dana Jansens
cbfa27759d extra braces.. why does the world hate me so? 2007-03-11 19:27:44 +00:00
Dana Jansens
d9601bc196 .. i am pretending to be mika :D :D ok this time for real 2007-03-11 19:27:16 +00:00
Dana Jansens
d98a6183a3 oh.. wasted verbosity.. *strums guitar* 2007-03-11 19:26:28 +00:00
Dana Jansens
e714fa7351 rewrite the focus steal prevention code to clean it up hopefully a bit. also don't steal focus from globally active focus model clients 2007-03-11 19:25:57 +00:00
Dana Jansens
6714a0e2ca Honor transient_for=Root, even thought this is crap and breaks some KDE stuff. Also include a big comment as to why this is suck. 2007-03-11 19:15:28 +00:00
Dana Jansens
7229bea3c6 client_configure_full is trying to move a window, it shouldn't determine the window's monitor from its current position, but from the new position instead. move client_monitor()'s logic into screen, more generically, and let client_configure_full use that 2007-03-11 17:34:07 +00:00
Dana Jansens
62a39c4c70 stacking has been made more reliable with groups and group transients.
this was a pretty invasive change in client.c though, so it may break things?

it did expose some bugginess in client_calc_layer, which is now better than ever, hopefully there isn't more to be found.
2007-03-11 16:58:19 +00:00
Dana Jansens
2c98204dfe make _NET_ACTIVE_WINDOW requests look at the timestamp when the user didn't
request it
2007-03-11 14:17:14 +00:00
Dana Jansens
19b480058e wow... this is a big commit...
all related to _NET_WM_USER_TIME and focus stealing prevention

a) add launcher startup notification. this means when you run something from
   the openbox menu or a key/mouse binding, that startup notification will go
   on in openbox and other applications like your panel or something
b) add the _NET_WM_USER_TIME property for windows
c) use the _NET_WM_USER_TIME data and startup notification to prevent focus
   stealing.
d) cookie party !! ! all are invited.
e) oh yeah, and pass around timestamps for a lot more things. like, when you
   run an action, send the timestamp for the event that is running the action.
   this is important for startup notification. this also affects menus.
f) yes.. cookies..

would it be a good idea to disable focus stealing prevention if a window takes
too long to load? i mean.. maybe after a certain length of time, a user can't be
expected to not do anything in any other windows, but would they still want the
new application to focus then? HMM. open question i guess..
2007-03-11 04:44:15 +00:00
Dana Jansens
9d6e390765 add the _NET_WM_USER_TIME property support. When focus_new is enabled, don't focus new windows if the user is doing something in another window since it launched. If we can tell when it launched, either from the _NET_WM_USER_TIME or from startup notification. 2007-03-11 02:06:34 +00:00
Dana Jansens
bd19fd06db remove the kde icon hint, they use the EWMH icon now 2007-03-11 00:59:13 +00:00
Dana Jansens
f6265e82e6 1) Remove support for the Urgent hint. This will no longer do anything within Openbox
2) Add support for _NET_WM_STATE_DEMANDS_ATTENTION. Yay!
2007-03-10 23:57:33 +00:00
Dana Jansens
ec67e96583 make startup notification a little more robust. obconf is just broken, between
the application and it's .desktop.
2007-03-10 22:52:50 +00:00
Dana Jansens
49dd40d99f no longer honor transient_for = None or Root. it violates the ICCCM and is causing problems. there are proper ways to make group transient windows with the EWMH. 2007-03-10 20:52:04 +00:00
Dana Jansens
4fa19b5985 more cleverness for window placing.
make sure its 10% on the screen in some direction always..

but if the application is placing itself, make sure its on the screen entirely,
and also put it entirely on one monitor if you have xinerama.

if it's bigger than the monitor's space though, it won't do anything with it..
2007-03-10 01:08:19 +00:00
Dana Jansens
ae246097a5 let you put windows with the titlebar off screen.. for mikachu.
but also don't let applications put themselves under the struts!
2007-03-10 00:44:43 +00:00
Dana Jansens
86b809df8a oops... I'm combining two different things in this commit... so I'll try be clear
1. when another wm requests to replace openbox, openbox exits. but the SM will just restart openbox unless we tell it not to. so now ob_exit_replace() will change the session manager's view of openbox to not restart it. that way the new WM will be able to run.

2. allow windows to move themselves off of the screen 90% of the way, if they really want to. but only 90% to the left, right, and bottom of the screen. it won't let the app move off the top of the screen on its own at all now, since hiding the titlebar on you without you being a part of the process is pretty darn evil!

this is really to address bug # 2982 - for the tilda application. but i guess if windows really want to move off the screen, who's to say no? also, every other window manager will let them - except metacity won't let them on the left/top side of the screen.
2007-03-04 09:01:52 +00:00
Dana Jansens
c07095acb7 better string matching for duplicate title numbering. this will check against the whole window's title. it used to check less than the full length sometimes. thanks to logan for patches and ideas! 2007-03-04 07:54:21 +00:00
Dana Jansens
65f0c70851 pretty brackets 2007-03-03 03:53:10 +00:00
Dana Jansens
4084f5d82d fix for per-application focus settings. properly use all the possible values (1, 0, and -1) 2007-03-02 22:44:38 +00:00
Dana Jansens
140c5313cf only update the screen areas when a window actually has a strut (or when the strut changes), don't waste extra calls to screen areas, because it makes people redraw when they don't need to 2007-03-02 15:19:39 +00:00
Dana Jansens
80a6f06c0a support clients which use true transparency 32-bit visuals.
this requires that when a client is using a 32-bit visual, we have to
make the frame windows that sit underneath it to use the same visual (and a
colormap which matches it)
2007-03-02 06:01:16 +00:00
Dana Jansens
78af5d15e9 this includes a number of things since my magnificent return....
1. some random compiling/style cleanups
2. some bigfixes
 - mislogic in per-window-settings and focusing new windows
 - use client_can_focus rather than checking variables for directional focus
 - MAYBE fix all those lock-ups forever. using event_curtime (a new variable) now instead of event_lasttime. event_lasttime is still used however when the event being processed did not have a time associated with it. this may or may not be a problem, and will be seen.
3. um.. i forget
4. oh yeah, 3rd party docks are now treated like the internal ob dock irt focus. that is, clicking on them won't pass them focus. this is going to be ratified as expected behavior in the wm-spec just now. if docks/panels want focus they can request it with _net_active_window, and then they can have all the focus they want! one day alt-tabbing around dock windows might be nice. but not until the ob dock is moved out into a separate application. going to have to add a wmapp selection and stuff for that though... ugly. who uses wmdockapps anymore !? someone must.. *sigh*
2007-03-02 02:23:00 +00:00
Mikael Magnusson
d3d4aa2987 80 cols 2006-11-15 21:12:06 +00:00
Mikael Magnusson
59d35252dd dont use nonexisting functions 2006-10-31 14:40:32 +00:00
Mikael Magnusson
b18846db69 Add MoveFromEdge* actions, shorten client_directional_edge_search with some handy #defines 2006-10-31 03:33:21 +00:00
Mikael Magnusson
b9532883a2 dont use the keepBorder option for mwm hinted windows after all, but do honor the mwm_decor_border hint instead 2006-09-12 20:26:00 +00:00
Mikael Magnusson
96eab1423f oops, added borders to windows when keepborder was on and they didnt have one to start with, ie docks etc 2006-08-31 13:43:19 +00:00
Mikael Magnusson
4d50b21835 update copyright step 1 2006-08-22 16:37:35 +00:00
Mikael Magnusson
c234ed9ecd maybe fix transients placed offscreen under certain conditions 2006-08-21 20:39:42 +00:00
Mikael Magnusson
d77c8f62f2 a more proper fix for the client list menu trying to activate a closed client, no difference on end result 2006-08-19 20:34:27 +00:00
Mikael Magnusson
3b56988069 dont flicker when setting desktop by per app settings 2006-08-19 17:55:31 +00:00
Mikael Magnusson
39f6b8ca71 forgot to check if perapp settings said to put window on all desktops 2006-08-19 17:50:12 +00:00
Mikael Magnusson
34269a34e1 lets not change the stacking before we add the window to the stacking stack 2006-08-19 15:35:23 +00:00
Mikael Magnusson
1de9c1901c fix a silly copy paste bug, titlenumber should now be disableable 2006-08-18 21:23:02 +00:00
Mikael Magnusson
83a0303dd7 add option titleNumber in theme section to disable the little [x] that you get after identical window titles 2006-08-16 19:32:13 +00:00
Mikael Magnusson
8eea64ca08 adjust logic to be... logical 2006-08-16 18:11:47 +00:00
Mikael Magnusson
5b288939ab try utf8 for WM_NAME if locale fails, really the _locale functions in prop.c are busted and should be fixed but i have no idea how. 2006-08-16 16:51:00 +00:00
Mikael Magnusson
dce6247e69 really fix focus_last? 2006-08-04 19:56:42 +00:00
Mikael Magnusson
97719044b1 s/_/./ 2006-08-02 17:40:23 +00:00
Mikael Magnusson
6a7c0b893a s/self/settings/ 2006-08-02 17:37:05 +00:00
Mikael Magnusson
05c0dbfedf be paranoid about programs setting 0 resize increments, which results in a divide by zero, which is in turn bad 2006-08-02 16:36:29 +00:00
Mikael Magnusson
d2fb93e8af remove bogus check for handle width in client_setup_decor_and_functions resulting in handles not being drawn if a theme with handle width = 0 is used when that function is called for a window and a theme with handle with > 0 is then loaded. 2006-08-02 06:07:12 +00:00
Mikael Magnusson
9fe211a1ca remove an old comment 2006-08-01 23:59:27 +00:00
Mikael Magnusson
e0aa54a891 rip out the VIDMODE extension stuff. this was only used to size fullscreen windows to the viewport, i doubt anyone is actually using it and it interacts very badly with xinerama. 2006-06-11 09:47:53 +00:00
Mikael Magnusson
0f80c6ab40 not surprisingly, there was a typo 2006-06-09 14:53:36 +00:00
Mikael Magnusson
e72a1232fa if this works i will be a bit amazed, add class matching, and allow to match either name or class or both 2006-06-09 14:52:06 +00:00
Mikael Magnusson
d4b7340454 changing props need client_change_state 2006-06-09 14:29:54 +00:00
Mikael Magnusson
94a0ea2150 fix2 2006-06-09 14:19:59 +00:00
Mikael Magnusson
2658610ae2 fix 2006-06-09 14:17:15 +00:00
Mikael Magnusson
ff04e2c9a9 add the rest of the possible states to per app settings, and fix some mem leaks in the code that _set_ the per app list 2006-06-09 14:14:17 +00:00
Mikael Magnusson
8af51d8a1b add role matching to per app settings and fix a small memleak in the code that frees the per app list 2006-06-09 12:47:48 +00:00
Mikael Magnusson
c63938f765 fix 2006-06-08 11:37:51 +00:00
Mikael Magnusson
de1559a094 move stuff around some more 2006-06-08 11:36:43 +00:00
Mikael Magnusson
f80ab241f3 some notes to self 2006-06-08 11:05:29 +00:00