nilix/openbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

We were grabbing SubstructureNotifyMask on the root window. I don't know why.. It meant that we got unmap notifies for windows we weren't even managing and stuff. It ended up breaking VLC when it mapped-unmapped-mapped a window. We grab StructureNotify for all the clients, so I am not sure why this was ever there.

Browse source
This commit is contained in:
Dana Jansens 2007-03-11 22:16:42 +00:00
parent cbfa27759d
commit e2b3a32aed
2 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
openbox/client.c
View file

@ -2,7 +2,7 @@
client.c for the Openbox window manager client.c for the Openbox window manager
Copyright (c) 2006 Mikael Magnusson Copyright (c) 2006 Mikael Magnusson
Copyright (c) 2003 Ben Jansens Copyright (c) 2003-2007 Dana Jansens
This program is free software; you can redistribute it and/or modify This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by it under the terms of the GNU General Public License as published by
@ -2004,8 +2004,6 @@ static void client_calc_layer_recursive(ObClient *self, ObClient *orig,
own = calc_layer(self); own = calc_layer(self);
self->layer = MAX(own, min); self->layer = MAX(own, min);
ob_debug("layer for %s: %d\n", self->title, self->layer);
for (it = self->transients; it; it = g_slist_next(it)) for (it = self->transients; it; it = g_slist_next(it))
client_calc_layer_recursive(it->data, orig, client_calc_layer_recursive(it->data, orig,
self->layer, self->layer,

4
openbox/screen.c
View file

@ -2,7 +2,7 @@
screen.c for the Openbox window manager screen.c for the Openbox window manager
Copyright (c) 2006 Mikael Magnusson Copyright (c) 2006 Mikael Magnusson
Copyright (c) 2003 Ben Jansens Copyright (c) 2003-2007 Dana Jansens
This program is free software; you can redistribute it and/or modify This program is free software; you can redistribute it and/or modify
it under the terms of the GNU General Public License as published by it under the terms of the GNU General Public License as published by
@ -45,7 +45,7 @@
/*! The event mask to grab on the root window */ /*! The event mask to grab on the root window */
#define ROOT_EVENTMASK (StructureNotifyMask | PropertyChangeMask | \ #define ROOT_EVENTMASK (StructureNotifyMask | PropertyChangeMask | \
EnterWindowMask | LeaveWindowMask | \ EnterWindowMask | LeaveWindowMask | \
SubstructureNotifyMask | SubstructureRedirectMask | \ SubstructureRedirectMask | \
ButtonPressMask | ButtonReleaseMask | ButtonMotionMask) ButtonPressMask | ButtonReleaseMask | ButtonMotionMask)
guint screen_num_desktops; guint screen_num_desktops;