nilix/openbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

proper check to see if something was raised, the it==NULL would cause it to always return, incorrectly.

Browse source
This commit is contained in:
Dana Jansens 2003-05-18 17:37:03 +00:00
parent 993fc6226d
commit cea19c78c1
1 changed files with 6 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
openbox/stacking.c
View file

@ -112,6 +112,7 @@ void stacking_raise(ObWindow *window)
if (WINDOW_IS_CLIENT(window)) { if (WINDOW_IS_CLIENT(window)) {
Client *client = WINDOW_AS_CLIENT(window); Client *client = WINDOW_AS_CLIENT(window);
/* move up the transient chain as far as possible first */ /* move up the transient chain as far as possible first */
if (client->transient_for) { if (client->transient_for) {
if (client->transient_for != TRAN_GROUP) { if (client->transient_for != TRAN_GROUP) {
@ -119,15 +120,18 @@ void stacking_raise(ObWindow *window)
return; return;
} else { } else {
GSList *it; GSList *it;
gboolean raised = FALSE;
for (it = client->group->members; it; it = it->next) { for (it = client->group->members; it; it = it->next) {
Client *c = it->data; Client *c = it->data;
/* checking transient_for prevents infinate loops! */ /* checking transient_for prevents infinate loops! */
if (c != client && !c->transient_for) if (c != client && !c->transient_for) {
stacking_raise(it->data); stacking_raise(it->data);
raised = TRUE;
}
} }
if (it == NULL) return; if (raised) return;
} }
} }
} }