better comments for the frame and its widgets' adjust() method

This commit is contained in:
Dana Jansens 2002-12-28 19:03:05 +00:00
parent 1e7c9071de
commit b8653c3ab8
5 changed files with 14 additions and 15 deletions

View file

@ -81,7 +81,7 @@ void OBBackgroundWidget::unfocus()
void OBBackgroundWidget::adjust() void OBBackgroundWidget::adjust()
{ {
// XXX: adjust shit // nothing to adjust here. its done in OBFrame::adjustSize
} }
} }

View file

@ -132,7 +132,7 @@ void OBButtonWidget::update()
void OBButtonWidget::adjust() void OBButtonWidget::adjust()
{ {
// XXX: adjust shit // nothing to adjust. no children.
} }

View file

@ -116,6 +116,7 @@ void OBFrame::unfocus()
void OBFrame::adjust() void OBFrame::adjust()
{ {
// the party all happens in adjustSize
} }
@ -128,6 +129,7 @@ void OBFrame::adjustSize()
int width; // the width of the client and its border int width; // the width of the client and its border
int bwidth; // width to make borders int bwidth; // width to make borders
int cbwidth; // width of the inner client border int cbwidth; // width of the inner client border
const int bevel = _style->getBevelWidth();
if (_decorations & OBClient::Decor_Border) { if (_decorations & OBClient::Decor_Border) {
bwidth = _style->getBorderWidth(); bwidth = _style->getBorderWidth();
@ -151,33 +153,31 @@ void OBFrame::adjustSize()
_titlebar.setGeometry(-bwidth, _titlebar.setGeometry(-bwidth,
-bwidth, -bwidth,
width, width,
(_style->getFont()->height() + _style->getFont()->height() + bevel * 2);
_style->getBevelWidth() * 2));
_innersize.top += _titlebar.height() + bwidth; _innersize.top += _titlebar.height() + bwidth;
// set the label size // set the label size
_label.setGeometry(0, _style->getBevelWidth(), _label.setGeometry(0, bevel, width, _style->getFont()->height());
width, _style->getFont()->height());
// set the buttons sizes // set the buttons sizes
if (_decorations & OBClient::Decor_Iconify) if (_decorations & OBClient::Decor_Iconify)
_button_iconify.setGeometry(0, _style->getBevelWidth() + 1, _button_iconify.setGeometry(0, bevel + 1,
_label.height() - 2, _label.height() - 2,
_label.height() - 2); _label.height() - 2);
if (_decorations & OBClient::Decor_Maximize) if (_decorations & OBClient::Decor_Maximize)
_button_max.setGeometry(0, _style->getBevelWidth() + 1, _button_max.setGeometry(0, bevel + 1,
_label.height() - 2, _label.height() - 2,
_label.height() - 2); _label.height() - 2);
if (_decorations & OBClient::Decor_Sticky) if (_decorations & OBClient::Decor_Sticky)
_button_stick.setGeometry(0, _style->getBevelWidth() + 1, _button_stick.setGeometry(0, bevel + 1,
_label.height() - 2, _label.height() - 2,
_label.height() - 2); _label.height() - 2);
if (_decorations & OBClient::Decor_Close) if (_decorations & OBClient::Decor_Close)
_button_close.setGeometry(0, _style->getBevelWidth() + 1, _button_close.setGeometry(0, bevel + 1,
_label.height() - 2, _label.height() - 2,
_label.height() - 2); _label.height() - 2);
// separation between titlebar elements // separation between titlebar elements
const int sep = _style->getBevelWidth() + 1; const int sep = bevel + 1;
std::string layout = "SLIMC"; // XXX: get this from somewhere std::string layout = "SLIMC"; // XXX: get this from somewhere
// XXX: it is REQUIRED that by this point, the string only has one of each // XXX: it is REQUIRED that by this point, the string only has one of each
@ -284,8 +284,6 @@ void OBFrame::adjustSize()
else else
_handle.hide(true); _handle.hide(true);
// XXX: more is gunna have to happen here
_size.left = _innersize.left + bwidth; _size.left = _innersize.left + bwidth;
_size.right = _innersize.right + bwidth; _size.right = _innersize.right + bwidth;
_size.top = _innersize.top + bwidth; _size.top = _innersize.top + bwidth;

View file

@ -93,8 +93,9 @@ public:
//! Set the style to decorate the frame with //! Set the style to decorate the frame with
virtual void setStyle(otk::Style *style); virtual void setStyle(otk::Style *style);
//! Realign children //! Empty overridden method to prevent automatic alignment of children
virtual void adjust(); virtual void adjust();
//! Displays focused decorations //! Displays focused decorations
virtual void focus(); virtual void focus();
//! Displays unfocused decorations //! Displays unfocused decorations

View file

@ -113,7 +113,7 @@ void OBLabelWidget::update()
void OBLabelWidget::adjust() void OBLabelWidget::adjust()
{ {
// XXX: adjust shit // nothing to adjust. no children.
} }
} }