nilix/openbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

I meant to check for windows placed by programs, not windows not placed by the user. Now checks for windows placed by programs and not placed by user. This excludes placement schemes which the former check didn't, resulting in some brokenness, particularly with xinerama.

Browse source
This commit is contained in:
Mikael Magnusson 2005-09-13 12:13:13 +00:00
parent 6236d2bcc2
commit 9df57ff1b5
1 changed files with 12 additions and 9 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

21
openbox/client.c
View file

@ -349,11 +349,17 @@ void client_manage(Window window)
self->frame->area.width, self->frame->area.width,
self->frame->area.height, self->frame->area.height,
/* non-normal clients has less rules, and /* non-normal clients has less rules, and
windows that are being restored from a session windows that are being restored from a
do also. we can assume you want it back where session do also. we can assume you want
you saved it. Clients saying the user placed it back where you saved it. Clients saying
them are also spared from the evil rules */ they placed themselves are subjected to
!(self->positioned & USPosition) && harder rules, ones that are placed by
place.c or by the user are allowed partially
off-screen and on xinerama divides (ie,
it is up to the placement routines to avoid
the xinerama divides) */
((self->positioned & PPosition) &&
!(self->positioned & USPosition)) &&
client_normal(self) && client_normal(self) &&
!self->session); !self->session);
if (x != ox || y != oy) if (x != ox || y != oy)
@ -615,8 +621,8 @@ gboolean client_find_onscreen(ObClient *self, gint *x, gint *y, gint w, gint h,
/* XXX watch for xinerama dead areas */ /* XXX watch for xinerama dead areas */
/* This makes sure windows aren't entirely outside of the screen so you /* This makes sure windows aren't entirely outside of the screen so you
* can't see them at all */ * can't see them at all */
a = screen_area(self->desktop);
if (client_normal(self)) { if (client_normal(self)) {
a = screen_area(self->desktop);
if (!self->strut.right && *x >= a->x + a->width - 1) if (!self->strut.right && *x >= a->x + a->width - 1)
*x = a->x + a->width - self->frame->area.width; *x = a->x + a->width - self->frame->area.width;
if (!self->strut.bottom && *y >= a->y + a->height - 1) if (!self->strut.bottom && *y >= a->y + a->height - 1)
@ -638,9 +644,6 @@ gboolean client_find_onscreen(ObClient *self, gint *x, gint *y, gint w, gint h,
* remember to fix the placement stuff to avoid it also and * remember to fix the placement stuff to avoid it also and
* then remove this XXX */ * then remove this XXX */
a = screen_physical_area_monitor(client_monitor(self)); a = screen_physical_area_monitor(client_monitor(self));
/* this is ben's MOZILLA BITCHSLAP. "oh ya it fucking feels good.
Java can suck it too." */
/* dont let windows map/move into the strut unless they /* dont let windows map/move into the strut unless they
are bigger than the available area */ are bigger than the available area */
if (w <= a->width) { if (w <= a->width) {