nilix/openbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

don't manage override_redirect windows.

Browse source 
don't manage windows for whome get attributes fails.
validate the client before managing it.
This commit is contained in:
Dana Jansens 2003-01-29 08:59:13 +00:00
parent 39c6969de2
commit 6c5c7fd04b
1 changed files with 19 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
src/screen.cc
View file

@ -433,16 +433,34 @@ void Screen::manageWindow(Window window)
Client *client = 0;
XWMHints *wmhint;
XSetWindowAttributes attrib_set;
XEvent e;
XWindowAttributes attrib;
otk::display->grab();
// check if it has already been unmapped by the time we started mapping
// the grab does a sync so we don't have to here
if (XCheckTypedWindowEvent(**otk::display, window, DestroyNotify, &e) ||
XCheckTypedWindowEvent(**otk::display, window, UnmapNotify, &e)) {
XPutBackEvent(**otk::display, &e);
otk::display->ungrab();
return; // don't manage it
}
if (!XGetWindowAttributes(**otk::display, window, &attrib) ||
attrib.override_redirect) {
otk::display->ungrab();
return; // don't manage it
}
// is the window a docking app
if ((wmhint = XGetWMHints(**otk::display, window))) {
if ((wmhint->flags & StateHint) &&
wmhint->initial_state == WithdrawnState) {
//slit->addClient(w); // XXX: make dock apps work!
otk::display->ungrab();
otk::display->ungrab();
XFree(wmhint);
return;
}