nilix/openbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

add the notion of "application windows" meaning normal or dialog type windows.

Browse source 
let you alt-tab to non-application windows when they dont have an application window in their group
This commit is contained in:
Dana Jansens 2007-05-03 20:57:40 +00:00
parent e0e1d4ba7e
commit 5784f11132
3 changed files with 28 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

20
openbox/client.c
View file

@ -2198,6 +2198,12 @@ gboolean client_normal(ObClient *self) {
self->type == OB_CLIENT_TYPE_SPLASH);
}
gboolean client_application(ObClient *self)
{
return (self->type == OB_CLIENT_TYPE_NORMAL ||
self->type == OB_CLIENT_TYPE_DIALOG);
}
static void client_apply_startup_state(ObClient *self, gint x, gint y)
{
gboolean pos = FALSE; /* has the window's position been configured? */
@ -3633,3 +3639,17 @@ gboolean client_has_group_siblings(ObClient *self)
{
return self->group && self->group->members->next;
}
gboolean client_has_application_group_siblings(ObClient *self)
{
GSList *it;
if (!self->group) return FALSE;
for (it = self->group->members; it; it = g_slist_next(it)) {
ObClient *c = it->data;
if (c != self && client_application(c))
return TRUE;
}
return FALSE;
}

7
openbox/client.h
View file

@ -348,6 +348,11 @@ gboolean client_should_show(ObClient *self);
to them in a number of places regarding focus or user interaction. */
gboolean client_normal(ObClient *self);
/*! Returns if the window is one of an application's main windows (normal or
dialog type) rather than an accessory window (utilty, menu, etc) or a
non-normal window */
gboolean client_application(ObClient *self);
/* Returns if the window is focused */
gboolean client_focused(ObClient *self);
@ -661,4 +666,6 @@ ObClient* client_under_pointer();
gboolean client_has_group_siblings(ObClient *self);
gboolean client_has_application_group_siblings(ObClient *self);
#endif

2
openbox/focus.c
View file

@ -475,7 +475,7 @@ static gboolean valid_focus_target(ObClient *ft, gboolean dock_windows)
else
ok = (ft->type == OB_CLIENT_TYPE_NORMAL ||
ft->type == OB_CLIENT_TYPE_DIALOG ||
(!client_has_group_siblings(ft) &&
(!client_has_application_group_siblings(ft) &&
(ft->type == OB_CLIENT_TYPE_TOOLBAR ||
ft->type == OB_CLIENT_TYPE_MENU ||
ft->type == OB_CLIENT_TYPE_UTILITY)));