nilix/openbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

i remembered why i remvoed the fake enter events from press type actions moving windows around. it makes for focus events with notifywhilegrab. remove it and make a comment explaining why.

Browse source
This commit is contained in:
Dana Jansens 2007-05-23 17:34:09 +00:00
parent 192cc6b4f4
commit 48314dc246
1 changed files with 9 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
openbox/action.c
View file

@ -47,18 +47,17 @@ static void client_action_end(union ActionData *data)
{
if (config_focus_follow)
if (data->any.context != OB_FRAME_CONTEXT_CLIENT) {
if (!data->any.button && data->any.c) {
if (!data->any.button && data->any.c)
event_ignore_all_queued_enters();
} else {
ObClient *c;
else {
/* we USED to create a fake enter event here, so that when you
used a Press context, and the button was still down,
you could still get enter events that weren't
NotifyWhileGrabbed.
/* usually this is sorta redundant, but with a press action
that moves windows our from under the cursor, the enter
event will come as a GrabNotify which is ignored, so this
makes a fake enter event
*/
if ((c = client_under_pointer()))
event_enter_client(c);
only problem with this is that then the resulting focus
change events can ALSO be NotifyWhileGrabbed. And that is
bad. So, don't create fake enter events anymore. */
}
}
}