nilix/openbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix use after free in menu_entry_frame_free

Browse source
This commit is contained in:
Edward Sheldrake 2014-10-28 01:28:35 +01:00 committed by Mikael Magnusson
parent 130075de74
commit 26951b0d4c
1 changed files with 1 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
openbox/menuframe.c
View file

@ -203,8 +203,6 @@ static ObMenuEntryFrame* menu_entry_frame_new(ObMenuEntry *entry,
static void menu_entry_frame_free(ObMenuEntryFrame *self) static void menu_entry_frame_free(ObMenuEntryFrame *self)
{ {
if (self) { if (self) {
menu_entry_unref(self->entry);
window_remove(self->window); window_remove(self->window);
XDestroyWindow(obt_display, self->text); XDestroyWindow(obt_display, self->text);
@ -221,6 +219,7 @@ static void menu_entry_frame_free(ObMenuEntryFrame *self)
g_hash_table_remove(menu_frame_map, &self->bullet); g_hash_table_remove(menu_frame_map, &self->bullet);
} }
menu_entry_unref(self->entry);
g_slice_free(ObMenuEntryFrame, self); g_slice_free(ObMenuEntryFrame, self);
} }
} }