nilix/openbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

some improvements on how group transients get their transient pointers, needed after r6022.

Browse source
This commit is contained in:
Dana Jansens 2007-05-04 04:25:44 +00:00
parent 5fefac87b9
commit 07af4a6184
1 changed files with 19 additions and 10 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

29
openbox/client.c
View file

@ -915,7 +915,10 @@ static void client_get_all(ObClient *self)
/* The transient hint is used to pick a type, but the type can also affect /* The transient hint is used to pick a type, but the type can also affect
transiency (dialogs are always made transients of their group if they transiency (dialogs are always made transients of their group if they
have one). This is Havoc's idea, but it is needed to make some apps have one). This is Havoc's idea, but it is needed to make some apps
work right (eg tsclient). */ work right (eg tsclient).
I also have made non-application type windows be transients based on
their type, like dialogs.
*/
client_update_transient_for(self); client_update_transient_for(self);
client_get_type(self);/* this can change the mwmhints for special cases */ client_get_type(self);/* this can change the mwmhints for special cases */
client_get_state(self); client_get_state(self);
@ -1643,7 +1646,8 @@ void client_update_wmhints(ObClient *self)
{ {
ObClient *c = it->data; ObClient *c = it->data;
if (c != self && !c->transient_for) if (c != self && (!c->transient_for ||
c->transient_for != OB_TRAN_GROUP))
c->transients = g_slist_remove(c->transients, c->transients = g_slist_remove(c->transients,
self); self);
} }
@ -1652,12 +1656,23 @@ void client_update_wmhints(ObClient *self)
group_remove(self->group, self); group_remove(self->group, self);
self->group = NULL; self->group = NULL;
} }
/* because the self->transient flag wont change from this call,
we don't need to update the window's type and such, only its
transient_for, and the transients lists of other windows in
the group may be affected
do this before adding transients from the group so we know if
we are actually transient for the group or not.
*/
client_update_transient_for(self);
if (hints->window_group != None) { if (hints->window_group != None) {
self->group = group_add(hints->window_group, self); self->group = group_add(hints->window_group, self);
/* i can only have transients from the group if i am not /* i can only have transients from the group if i am not
transient myself */ transient for the group myself */
if (!self->transient_for) { if (self->transient_for != OB_TRAN_GROUP) {
/* add other transients of the group that are already /* add other transients of the group that are already
set up */ set up */
for (it = self->group->members; it; for (it = self->group->members; it;
@ -1670,12 +1685,6 @@ void client_update_wmhints(ObClient *self)
} }
} }
} }
/* because the self->transient flag wont change from this call,
we don't need to update the window's type and such, only its
transient_for, and the transients lists of other windows in
the group may be affected */
client_update_transient_for(self);
} }
/* the WM_HINTS can contain an icon */ /* the WM_HINTS can contain an icon */