Cosmetic

NEWS

@@ -10,7 +10,7 @@ Minor Bugfixes:
     * working autorepeat keys
     * working vertical rotated Tabs and Toolbar
 
-Featuere:
+Features:
     * The improved TypeAhead sytem is not limited to matches on beginning
       of menu items anymore, it matches everywhere.
     * Minor tweaks to the i18n system

src/Resources.cc

@@ -26,17 +26,11 @@
 #include "WinButton.hh"
 
 #include "fluxbox.hh"
-
 #include "Layer.hh"
 
-#include <stdio.h>
 #include <string>
 #include <vector>
-#ifdef HAVE_CSTRING
+#include <cstring>
-  #include <cstring>
-#else
-  #include <string.h>
-#endif
 
 using std::string;
 using std::vector;

src/Screen.cc

@@ -1290,9 +1290,11 @@ void BScreen::rereadMenu() {
 }
 
 const std::string BScreen::windowMenuFilename() const {
-    if ((*resource.windowmenufile).empty())
+    std::string name = *resource.windowmenufile;
-        return Fluxbox::instance()->getDefaultDataFilename("windowmenu");
+    if (name.empty()) {
-    return *resource.windowmenufile;
+        name = Fluxbox::instance()->getDefaultDataFilename("windowmenu");
+    }
+    return name;
 }
 
 void BScreen::rereadWindowMenu() {

src/ScreenResource.cc

@@ -79,9 +79,9 @@ setFromString(const char *strval) {
 
 
 
-ScreenResource::ScreenResource(FbTk::ResourceManager &rm,
+ScreenResource::ScreenResource(FbTk::ResourceManager& rm,
-        const std::string &scrname,
+        const std::string& scrname,
-        const std::string &altscrname):
+        const std::string& altscrname):
     opaque_move(rm, true, scrname + ".opaqueMove", altscrname+".OpaqueMove"),
     full_max(rm, false, scrname+".fullMaximization", altscrname+".FullMaximization"),
     max_ignore_inc(rm, true, scrname+".maxIgnoreIncrement", altscrname+".MaxIgnoreIncrement"),

src/Window.cc

@@ -299,7 +299,7 @@ FluxboxWindow::FluxboxWindow(WinClient &client):
 
     // add the window to the focus list
     // always add to front on startup to keep the focus order the same
-    if (m_focused || Fluxbox::instance()->isStartup())
+    if (isFocused() || Fluxbox::instance()->isStartup())
         screen().focusControl().addFocusWinFront(*this);
     else
         screen().focusControl().addFocusWinBack(*this);
@@ -599,8 +599,8 @@ void FluxboxWindow::attachClient(WinClient &client, int x, int y) {
         delete old_win;
 
     } else { // client.fbwindow() == 0
-        associateClient(client);
 
+        associateClient(client);
         moveResizeClient(client);
 
         // right now, this block only happens with new windows or on restart
@@ -2390,10 +2390,13 @@ void FluxboxWindow::motionNotifyEvent(XMotionEvent &me) {
 
         // undraw rectangle before warping workspaces
         if (!screen().doOpaqueMove()) {
-            parent().drawRectangle(screen().rootTheme()->opGC(),
+            int bw = static_cast<int>(frame().window().borderWidth());
-                    m_last_move_x, m_last_move_y,
+            int w = static_cast<int>(frame().width()) + 2*bw -1;
-                    frame().width() + 2*frame().window().borderWidth()-1,
+            int h = static_cast<int>(frame().height()) + 2*bw - 1;
-                    frame().height() + 2*frame().window().borderWidth()-1);
+            if (w > 0 && h > 0) {
+                parent().drawRectangle(screen().rootTheme()->opGC(),
+                    m_last_move_x, m_last_move_y, w, h);
+            }
         }
 
         if (moved_x && screen().isWorkspaceWarping()) {
@@ -2444,10 +2447,12 @@ void FluxboxWindow::motionNotifyEvent(XMotionEvent &me) {
         // do not update display if another motion event is already pending
 
         if (!screen().doOpaqueMove()) {
-            parent().drawRectangle(screen().rootTheme()->opGC(),
+            int bw = frame().window().borderWidth();
-                    dx, dy,
+            int w = static_cast<int>(frame().width()) + 2*bw - 1;
-                    frame().width() + 2*frame().window().borderWidth()-1,
+            int h = static_cast<int>(frame().height()) + 2*bw - 1;
-                    frame().height() + 2*frame().window().borderWidth()-1);
+            if (w > 0 && h > 0) {
+                parent().drawRectangle(screen().rootTheme()->opGC(), dx, dy, w, h);
+            }
             m_last_move_x = dx;
             m_last_move_y = dy;
         } else {