nilix/fluxbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Make coverity happy

Browse source 
Coverity complaints about 'isdigit(whole_keyfile[pos])' is changing the
validity of 'keyfile' (which itself is just a copy of whole_keyfile.c_str()).

This might be a valid claim, it might be not. By using the 'keyfile'
variable we make Coverity happy and achieve the same behavior.
This commit is contained in:
Mathias Gumz 2015-01-16 10:45:39 +01:00
parent a65e9c686e
commit ad8e6da8ef
1 changed files with 3 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
util/fluxbox-update_configs.cc
View file

@ -30,19 +30,14 @@
#include <signal.h> #include <signal.h>
#endif // HAVE_SIGNAL_H #endif // HAVE_SIGNAL_H
#ifdef HAVE_CSTRING
#include <cstring>
#else
#include <string.h>
#endif
#include <sys/stat.h> #include <sys/stat.h>
#include <iostream> #include <iostream>
#include <fstream> #include <fstream>
#include <cstdlib>
#include <cstring>
#include <set> #include <set>
#include <map> #include <map>
#include <cstdlib>
#include <list> #include <list>
using std::cout; using std::cout;
@ -364,7 +359,7 @@ void update_update_keys_file_for_nextwindow_syntax_changes(FbTk::ResourceManager
break; break;
pos = whole_keyfile.find_first_not_of(" \t", pos); pos = whole_keyfile.find_first_not_of(" \t", pos);
if (pos != std::string::npos && isdigit(whole_keyfile[pos])) { if (pos != std::string::npos && isdigit(keyfile[pos])) {
char *endptr = 0; char *endptr = 0;
unsigned int mask = strtoul(keyfile + pos, &endptr, 0); unsigned int mask = strtoul(keyfile + pos, &endptr, 0);
string insert = ""; string insert = "";