nilix/fluxbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix typo / editor bug or something like that.

Browse source 
While running code analysis tools this issue popped up. As it is written it is
clearly a NOP, but the reason for why it is written that way remains unknown.
I suspect that it was a textfragment introduced by some repeat-function of the
used editor (think '.' in VIM). The code was introduced by commit a932a7a801
and looked like this in the original form:

   if(!XQueryTree(FbTk::App::instance()->display(), window().window(),
                  &root_return, &parent_return,
                  &children_return, &nchildren_return))
       parent_return=parent_return;//return;

Look at the outcommented return statement. I decided to return from that
function instead of the NOP.
This commit is contained in:
Mathias Gumz 2015-01-03 18:45:28 +01:00
parent bd519dd952
commit 65e0654249
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/FbTk/Container.cc
View file

@ -129,7 +129,7 @@ bool Container::moveItemTo(Item item, int x, int y) {
// get the root window // get the root window
if (!XQueryTree(display(), window(), if (!XQueryTree(display(), window(),
&root_return, &parent_return, &children_return, &nchildren_return)) &root_return, &parent_return, &children_return, &nchildren_return))
parent_return = parent_return; return false;
if (children_return != NULL) if (children_return != NULL)
XFree(children_return); XFree(children_return);