nilix/fluxbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Handle sizehint base_width / base_height being less than 0

Browse source 
Some applications supply -1 in base_width / base_height. One example is
the Preferences dialog of pcmanfm-qt:

WM_NORMAL_HINTS(WM_SIZE_HINTS):
  ...
  program specified base size: -1 by -1

Without this commit the program will crash due to overflow of unsigned int.
This commit is contained in:
Bo Simonsen 2020-04-14 20:42:38 +02:00 committed by Mathias Gumz
parent f48237e3ad
commit 419170668a
1 changed files with 3 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
src/WindowState.cc
View file

@ -113,8 +113,9 @@ void SizeHints::reset(const XSizeHints &sizehint) {
min_width = min_height = 1;
if (sizehint.flags & PBaseSize) {
base_width = sizehint.base_width;
base_height = sizehint.base_height;
base_width = std::max(sizehint.base_width, 0);
base_height = std::max(sizehint.base_height, 0);
if (!(sizehint.flags & PMinSize)) {
min_width = base_width;
min_height = base_height;