nilix/fluxbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Use correct buffer size for number2*()

Browse source
This commit is contained in:
Mathias Gumz 2015-01-03 18:39:09 +01:00
parent 362b5c191a
commit 3e76d43987
1 changed files with 6 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

9
src/FbTk/StringUtil.cc
View file

@ -69,6 +69,9 @@ using std::transform;
namespace { namespace {
const size_t DIGITS10_ULONGLONGINT = 20; // ULLONG_MAX = 18446744073709551615
const size_t DIGITS16_ULONGLONGINT = 18; // ULLONG_MAX = 0xffffffffffffffff
template <typename T> template <typename T>
int extractBigNumber(const char* in, T (*extractFunc)(const char*, char**, int), T& out) { int extractBigNumber(const char* in, T (*extractFunc)(const char*, char**, int), T& out) {
@ -170,14 +173,14 @@ int extractNumber(const std::string& in, unsigned long long& out) {
std::string number2String(long long num) { std::string number2String(long long num) {
char s[128]; char s[DIGITS10_ULONGLONGINT];
snprintf(s, sizeof(s), "%lld", num); snprintf(s, sizeof(s), "%lld", num);
return std::string(s); return std::string(s);
} }
std::string number2HexString(long long num) { std::string number2HexString(long long num) {
char s[17]; char s[DIGITS16_ULONGLONGINT];
snprintf(s, sizeof(s), "%lx", num); snprintf(s, sizeof(s), "%llx", num);
return std::string(s); return std::string(s);
} }