nilix/fluxbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Thought BadWindow was a return status on failure.

Browse source 
In fact its 0, thats why fluxbox sometimes crashes when freeing the
malformed structure.
This commit is contained in:
Gregor Bollerhey 2014-01-08 00:31:03 +01:00 committed by Jan Sucan
parent 35ce8b313a
commit 173a66346b
1 changed files with 3 additions and 5 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
src/SystemTray.cc
View file

@ -599,13 +599,11 @@ static int client_to_ordinal(const std::vector<std::string> left,
// based on the parsed order list and a given window returns an
// ordinal used to sort the tray icons.
auto Xdeleter = [](XClassHint *x){XFree(x);};
std::unique_ptr<XClassHint, decltype(Xdeleter)>
xclasshint (XAllocClassHint(), Xdeleter);
std::unique_ptr<XClassHint, int(*)(void*)>
xclasshint(XAllocClassHint(), XFree);
if(XGetClassHint(Fluxbox::instance()->display(),
i->window(), xclasshint.get()) != BadWindow)
i->window(), xclasshint.get()))
{
std::string classname(xclasshint.get()->res_class);