nilix/fluxbox
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix evaluating variables in ExportCmd

Browse source 
Don't evaluate trusted variables in *ExportCmd::parse as they will be
always false for SetEnv, Export and SetResourceValue and never executed
via fluxbox-remote.
This commit is contained in:
Maik Broemme 2015-12-03 00:44:44 +01:00 committed by Mathias Gumz
parent 05d860eda7
commit 0df41cf838
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
src/FbCommands.cc
View file

@ -175,7 +175,7 @@ FbTk::Command<void> *ExportCmd::parse(const string &command, const string &args,
if (command != "setresourcevalue") if (command != "setresourcevalue")
FbTk::StringUtil::removeTrailingWhitespace(name); FbTk::StringUtil::removeTrailingWhitespace(name);
size_t pos = name.find_first_of(command == "export" ? "=" : " \t"); size_t pos = name.find_first_of(command == "export" ? "=" : " \t");
if (pos == string::npos || pos == name.size() || !trusted) if (pos == string::npos || pos == name.size())
return 0; return 0;
string value = name.substr(pos + 1); string value = name.substr(pos + 1);